FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace `.substr` with `.slice` · nodejs/node@8653d92 · GitHub

/ node Public

Commit 8653d92

Browse files
authored and
marco-ippolito
committed
test: replace .substr with .slice
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 32839c6 commit 8653d92

13 files changed

Lines changed: 22 additions & 22 deletions

‎test/es-module/test-esm-exports.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ const { requireFromInside, importFromInside } = fromInside;
231231
});
232232

233233
function assertStartsWith(actual, expected) {
234-
const start = actual.toString().substr(0, expected.length);
234+
const start = actual.toString().slice(0, expected.length);
235235
strictEqual(start, expected);
236236
}
237237

‎test/es-module/test-esm-imports.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ requireFixture('#cjs').then(mustCall((actual) => {
124124
}));
125125

126126
function assertStartsWith(actual, expected) {
127-
const start = actual.toString().substr(0, expected.length);
127+
const start = actual.toString().slice(0, expected.length);
128128
strictEqual(start, expected);
129129
}
130130

‎test/parallel/test-crypto-authenticated.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ for (const test of TEST_CASES) {
284284
cipher.update('01234567', 'hex');
285285
cipher.final();
286286
const tag = cipher.getAuthTag();
287-
assert.strictEqual(tag.toString('hex'), fullTag.substr(0, 2 * e));
287+
assert.strictEqual(tag.toString('hex'), fullTag.slice(0, 2 * e));
288288
}
289289
}
290290

‎test/parallel/test-crypto-hmac.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,8 @@ for (let i = 0, l = rfc4231.length; i < l; i++) {
272272
.update(rfc4231[i].data)
273273
.digest('hex');
274274
if (rfc4231[i].truncate) {
275-
actual = actual.substr(0, 32); // first 128 bits == 32 hex chars
276-
strRes = strRes.substr(0, 32);
275+
actual = actual.slice(0, 32); // first 128 bits == 32 hex chars
276+
strRes = strRes.slice(0, 32);
277277
}
278278
const expected = rfc4231[i].hmac[hash];
279279
assert.strictEqual(

‎test/parallel/test-crypto-randomuuid.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ for (let n = 0; n < 130; n++) {
3434

3535
// Check that version 4 identifier was populated.
3636
assert.strictEqual(
37-
Buffer.from(uuid.substr(14, 2), 'hex')[0] & 0x40, 0x40);
37+
Buffer.from(uuid.slice(14, 16), 'hex')[0] & 0x40, 0x40);
3838

3939
// Check that clock_seq_hi_and_reserved was populated with reserved bits.
4040
assert.strictEqual(
41-
Buffer.from(uuid.substr(19, 2), 'hex')[0] & 0b1100_0000, 0b1000_0000);
41+
Buffer.from(uuid.slice(19, 21), 'hex')[0] & 0b1100_0000, 0b1000_0000);
4242
}
4343

4444
// Test non-buffered UUID's

‎test/parallel/test-fs-realpath.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ let root = '/';
4242
let assertEqualPath = assert.strictEqual;
4343
if (common.isWindows) {
4444
// Something like "C:\\"
45-
root = process.cwd().substr(0, 3);
45+
root = process.cwd().slice(0, 3);
4646
assertEqualPath = function(path_left, path_right, message) {
4747
assert
4848
.strictEqual(path_left.toLowerCase(), path_right.toLowerCase(), message);
@@ -367,7 +367,7 @@ function test_deep_symlink_mix(realpath, realpathSync, callback) {
367367
function test_non_symlinks(realpath, realpathSync, callback) {
368368
console.log('test_non_symlinks');
369369
const entrydir = path.dirname(tmpAbsDir);
370-
const entry = `${tmpAbsDir.substr(entrydir.length + 1)}/cycles/root.js`;
370+
const entry = `${tmpAbsDir.slice(entrydir.length + 1)}/cycles/root.js`;
371371
const expected = `${tmpAbsDir}/cycles/root.js`;
372372
const origcwd = process.cwd();
373373
process.chdir(entrydir);

‎test/parallel/test-http-content-length.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const server = http.createServer(function(req, res) {
2626
res.removeHeader('Date');
2727
res.setHeader('Keep-Alive', 'timeout=1');
2828

29-
switch (req.url.substr(1)) {
29+
switch (req.url.slice(1)) {
3030
case 'multiple-writes':
3131
delete req.headers.host;
3232
assert.deepStrictEqual(req.headers, expectedHeadersMultipleWrites);

‎test/parallel/test-http-upgrade-server.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ function test_upgrade_with_listener() {
100100
assert.strictEqual(typeof data, 'string');
101101

102102
if (state === 1) {
103-
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 101');
103+
assert.strictEqual(data.slice(0, 12), 'HTTP/1.1 101');
104104
assert.strictEqual(request_upgradeHead.toString('utf8'), 'WjN}|M(6');
105105
conn.write('test', 'utf8');
106106
} else if (state === 2) {
@@ -133,7 +133,7 @@ function test_upgrade_no_listener() {
133133

134134
conn.once('data', (data) => {
135135
assert.strictEqual(typeof data, 'string');
136-
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 200');
136+
assert.strictEqual(data.slice(0, 12), 'HTTP/1.1 200');
137137
conn.end();
138138
});
139139

@@ -153,7 +153,7 @@ function test_standard_http() {
153153

154154
conn.once('data', function(data) {
155155
assert.strictEqual(typeof data, 'string');
156-
assert.strictEqual(data.substr(0, 12), 'HTTP/1.1 200');
156+
assert.strictEqual(data.slice(0, 12), 'HTTP/1.1 200');
157157
conn.end();
158158
});
159159

‎test/parallel/test-path-dirname.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const common = require('../common');
33
const assert = require('assert');
44
const path = require('path');
55

6-
assert.strictEqual(path.dirname(__filename).substr(-13),
6+
assert.strictEqual(path.dirname(__filename).slice(-13),
77
common.isWindows ? 'test\\parallel' : 'test/parallel');
88

99
assert.strictEqual(path.posix.dirname('/a/b/'), '/a');

‎test/parallel/test-repl-tab-complete.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ testMe.complete('obj.', common.mustCall(function(error, data) {
584584

585585
data[0].forEach((key) => {
586586
if (!key || key === 'ele.biu') return;
587-
assert.notStrictEqual(ele[key.substr(4)], undefined);
587+
assert.notStrictEqual(ele[key.slice(4)], undefined);
588588
});
589589
}));
590590
});

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL