Commit 86c7c0a
committed
deps: V8: cherry-pick 6a4cd97d6691
Original commit message:
Merged: [parser] Fix AST func reindexing for function fields
AST reindexing has to skip visiting fields that are already in the
member initializer, as they will have already been visited when
visiting said initializer. This is the case for private fields and
fields with computed names.
However, the reindexer was incorrectly assuming that all properties
with a FunctionLiteral value are methods (and thus not fields, and
can safely be visited). This is not the case for fields with
function expression values.
Now, we correctly use the class property's "kind" when making this
visitation decision.
(cherry picked from commit a769ea7a4462115579ba87bc16fbffbae01310c1)
Bug: chromium:1132111
Tbr: leszeks@chromium.org
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I33ac5664bb5334e964d351de1ba7e2c57f3398f8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2465056
Commit-Queue: Adam Klein <adamk@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.6@{#24}
Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}
Refs: v8/v8@6a4cd97
PR-URL: #38275
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>1 parent b10cce1 commit 86c7c0a
3 files changed
Lines changed: 29 additions & 5 deletions
File tree
- deps/v8
- src/ast
- test/mjsunit/regress
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.34', | ||
| 39 | + 'v8_embedder_string': '-node.35', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -54,10 +54,10 @@ void AstFunctionLiteralIdReindexer::VisitClassLiteral(ClassLiteral* expr) { | |||
| 54 | 54 | // Private fields have their key and value present in | |
| 55 | 55 | // instance_members_initializer_function, so they will | |
| 56 | 56 | // already have been visited. | |
| 57 | - if (prop->value()->IsFunctionLiteral()) { | ||
| 58 | - Visit(prop->value()); | ||
| 59 | - } else { | ||
| 57 | + if (prop->kind() == ClassLiteralProperty::Kind::FIELD) { | ||
| 60 | 58 | CheckVisited(prop->value()); | |
| 59 | + } else { | ||
| 60 | + Visit(prop->value()); | ||
| 61 | 61 | } | |
| 62 | 62 | } | |
| 63 | 63 | ZonePtrList<ClassLiteral::Property>* props = expr->public_members(); | |
@@ -67,7 +67,8 @@ void AstFunctionLiteralIdReindexer::VisitClassLiteral(ClassLiteral* expr) { | |||
| 67 | 67 | // Public fields with computed names have their key | |
| 68 | 68 | // and value present in instance_members_initializer_function, so they will | |
| 69 | 69 | // already have been visited. | |
| 70 | - if (prop->is_computed_name() && !prop->value()->IsFunctionLiteral()) { | ||
| 70 | + if (prop->is_computed_name() && | ||
| 71 | + prop->kind() == ClassLiteralProperty::Kind::FIELD) { | ||
| 71 | 72 | if (!prop->key()->IsLiteral()) { | |
| 72 | 73 | CheckVisited(prop->key()); | |
| 73 | 74 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,23 @@ | |||
| 1 | + // Copyright 2020 the V8 project authors. All rights reserved. | ||
| 2 | + // Use of this source code is governed by a BSD-style license that can be | ||
| 3 | + // found in the LICENSE file. | ||
| 4 | + | ||
| 5 | + // Public function field with computed name | ||
| 6 | + eval(` | ||
| 7 | + buggy = ((bug = new class { [0] = x => 1337.0; }) => bug); | ||
| 8 | + `); | ||
| 9 | + | ||
| 10 | + // Public method with computed name | ||
| 11 | + eval(` | ||
| 12 | + buggy = ((bug = new class { [0](x) { return 1337.0}; }) => bug); | ||
| 13 | + `); | ||
| 14 | + | ||
| 15 | + // Private function field with computed name | ||
| 16 | + eval(` | ||
| 17 | + buggy = ((bug = new class { #foo = x => 1337.0; }) => bug); | ||
| 18 | + `); | ||
| 19 | + | ||
| 20 | + // Private method with computed name | ||
| 21 | + eval(` | ||
| 22 | + buggy = ((bug = new class { #foo(x) { return 1337.0; } }) => bug); | ||
| 23 | + `); | ||
0 commit comments