Commit 86ed87b
http2: fix reinjection check
We reinject when the sockets has already waiting
data, remarked by @mildsunrise
Co-authored-by: Alba Mendez <me@alba.sh>
PR-URL: #35678
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>1 parent 5833007 commit 86ed87b
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3144,7 +3144,7 @@ function connect(authority, options, listener) { | |||
| 3144 | 3144 | debug('Http2Session connect', options.createConnection); | |
| 3145 | 3145 | // Socket already has some buffered data - emulate receiving it | |
| 3146 | 3146 | // https://github.com/nodejs/node/issues/35475 | |
| 3147 | - if (typeof options.createConnection === 'function') { | ||
| 3147 | + if (socket && socket.readableLength) { | ||
| 3148 | 3148 | let buf; | |
| 3149 | 3149 | while ((buf = socket.read()) !== null) { | |
| 3150 | 3150 | debug(`Http2Session connect: injecting ${buf.length} already in buffer`); | |
0 commit comments