benchmark: remove unreachable code from crypto/hash-stream-creation · nodejs/node@878b2e7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 878b2e7

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

BethGriggs

committed

benchmark: remove unreachable code from crypto/hash-stream-creation

`hash.digest('buffer')` has returned a Buffer and not a string since at least Node.js 0.10.6. The benchmark, as it is written, will not work on any version of Node.js prior to 16.x (due to `Object.hasOwn()`) and certainly won't run on versions earlier than 0.10.6 due to const/let and probably other things. Remove impossible-to-reach code intended to accommodate Node.js earlier than 0.10.6. PR-URL: #41535 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent be63dc5 commit 878b2e7
Copy full SHA for 878b2e7

1 file changed

+1-5Lines changed: 1 addition & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark/crypto
  • hash-stream-creation.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/crypto/hash-stream-creation.js‎

Copy file name to clipboardExpand all lines: benchmark/crypto/hash-stream-creation.js

+1-5Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -52,11 +52,7 @@ function legacyWrite(algo, message, encoding, writes, len, outEnc) {
52	52	while (writes-- > 0) {
53	53	const h = crypto.createHash(algo);
54	54	h.update(message, encoding);
55		- let res = h.digest(outEnc);
56		-
57		- // Include buffer creation costs for older versions
58		- if (outEnc === 'buffer' && typeof res === 'string')
59		- res = Buffer.from(res, 'binary');
	55	+ h.digest(outEnc);
60	56	}
61	57
62	58	bench.end(gbits);

0 commit comments

Comments

0 (0)