Commit 8799f43
committed
http: revert "http: always emit close on req and res"
This reverts a commit that accidentally introduced a semver-major
change to Node 10 and broke userland code.
A subsequent fix to that change and documentation change are reverted
with it.
Revert "http: fix res emit close before user finish"
This reverts commit 2a9c833.
Revert "http: always emit close on req and res"
This reverts commit 8029a24.
Revert "doc: fix HTTP req/res 'close' description"
This reverts commit 8ab7ea6.
PR-URL: #21809
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>1 parent 3d05d82 commit 8799f43
3 files changed
Lines changed: 3 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1015,7 +1015,8 @@ interface. This is an [`EventEmitter`][] with the following events: | |||
| 1015 | 1015 | added: v0.6.7 | |
| 1016 | 1016 | --> | |
| 1017 | 1017 | ||
| 1018 | - Indicates that the underlying connection was terminated. | ||
| 1018 | + Indicates that the underlying connection was terminated before | ||
| 1019 | + [`response.end()`][] was called or able to flush. | ||
| 1019 | 1020 | ||
| 1020 | 1021 | ### Event: 'finish' | |
| 1021 | 1022 | <!-- YAML | |
@@ -1505,6 +1506,7 @@ added: v0.4.2 | |||
| 1505 | 1506 | --> | |
| 1506 | 1507 | ||
| 1507 | 1508 | Indicates that the underlying connection was closed. | |
| 1509 | + Just like `'end'`, this event occurs only once per response. | ||
| 1508 | 1510 | ||
| 1509 | 1511 | ### message.aborted | |
| 1510 | 1512 | <!-- YAML | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -561,8 +561,6 @@ function resOnFinish(req, res, socket, state, server) { | |||
| 561 | 561 | req._dump(); | |
| 562 | 562 | ||
| 563 | 563 | res.detachSocket(socket); | |
| 564 | - req.emit('close'); | ||
| 565 | - process.nextTick(emitCloseNT, res); | ||
| 566 | 564 | ||
| 567 | 565 | if (res._last) { | |
| 568 | 566 | if (typeof socket.destroySoon === 'function') { | |
@@ -585,10 +583,6 @@ function resOnFinish(req, res, socket, state, server) { | |||
| 585 | 583 | } | |
| 586 | 584 | } | |
| 587 | 585 | ||
| 588 | - function emitCloseNT(self) { | ||
| 589 | - self.emit('close'); | ||
| 590 | - } | ||
| 591 | - | ||
| 592 | 586 | // The following callback is issued after the headers have been read on a | |
| 593 | 587 | // new message. In this callback we setup the response object and pass it | |
| 594 | 588 | // to the user. | |
This file was deleted.
0 commit comments