Commit 8814d03
doc,lib,test: rename node-report to report
This commit completes the renaming of node-report to report
in order to better differentiate core's reporting from the
node-report npm module.
PR-URL: #26371
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 11bd5e0 commit 8814d03
4 files changed
Lines changed: 7 additions & 7 deletions
File tree
- doc/api
- lib/internal
- bootstrap
- process
- test/common
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -32,7 +32,7 @@ is provided below for reference. | |||
| 32 | 32 | "/home/nodeuser/project/node/out/Release/node", | |
| 33 | 33 | "--experimental-report", | |
| 34 | 34 | "--diagnostic-report-uncaught-exception", | |
| 35 | - "/home/nodeuser/project/node/test/node-report/test-exception.js", | ||
| 35 | + "/home/nodeuser/project/node/test/report/test-exception.js", | ||
| 36 | 36 | "child" | |
| 37 | 37 | ], | |
| 38 | 38 | "nodejsVersion": "v12.0.0-pre", | |
@@ -66,8 +66,8 @@ is provided below for reference. | |||
| 66 | 66 | "javascriptStack": { | |
| 67 | 67 | "message": "Error: *** test-exception.js: throwing uncaught Error", | |
| 68 | 68 | "stack": [ | |
| 69 | - "at myException (/home/nodeuser/project/node/test/node-report/test-exception.js:9:11)", | ||
| 70 | - "at Object.<anonymous> (/home/nodeuser/project/node/test/node-report/test-exception.js:12:3)", | ||
| 69 | + "at myException (/home/nodeuser/project/node/test/report/test-exception.js:9:11)", | ||
| 70 | + "at Object.<anonymous> (/home/nodeuser/project/node/test/report/test-exception.js:12:3)", | ||
| 71 | 71 | "at Module._compile (internal/modules/cjs/loader.js:718:30)", | |
| 72 | 72 | "at Object.Module._extensions..js (internal/modules/cjs/loader.js:729:10)", | |
| 73 | 73 | "at Module.load (internal/modules/cjs/loader.js:617:32)", | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,7 +11,7 @@ function prepareMainThreadExecution() { | |||
| 11 | 11 | // Only main thread receives signals. | |
| 12 | 12 | setupSignalHandlers(); | |
| 13 | 13 | ||
| 14 | - // Process initial configurations of node-report, if any. | ||
| 14 | + // Process initial diagnostic reporting configuration, if present. | ||
| 15 | 15 | initializeReport(); | |
| 16 | 16 | initializeReportSignalHandlers(); // Main-thread-only. | |
| 17 | 17 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -102,7 +102,7 @@ function createFatalException() { | |||
| 102 | 102 | // call that threw and was never cleared. So clear it now. | |
| 103 | 103 | clearDefaultTriggerAsyncId(); | |
| 104 | 104 | ||
| 105 | - // If node-report is enabled, call into its handler to see | ||
| 105 | + // If diagnostic reporting is enabled, call into its handler to see | ||
| 106 | 106 | // whether it is interested in handling the situation. | |
| 107 | 107 | // Ignore if the error is scoped inside a domain. | |
| 108 | 108 | // use == in the checks as we want to allow for null and undefined | |
@@ -119,7 +119,7 @@ function createFatalException() { | |||
| 119 | 119 | report.onUnCaughtException(er ? er.stack : undefined); | |
| 120 | 120 | } | |
| 121 | 121 | } | |
| 122 | - } catch {} // NOOP, node_report unavailable. | ||
| 122 | + } catch {} // Ignore the exception. Diagnostic reporting is unavailable. | ||
| 123 | 123 | } | |
| 124 | 124 | ||
| 125 | 125 | if (exceptionHandlerState.captureFn !== null) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -635,7 +635,7 @@ function skipIfInspectorDisabled() { | |||
| 635 | 635 | ||
| 636 | 636 | function skipIfReportDisabled() { | |
| 637 | 637 | if (!process.config.variables.node_report) { | |
| 638 | - skip('Node Report is disabled'); | ||
| 638 | + skip('Diagnostic reporting is disabled'); | ||
| 639 | 639 | } | |
| 640 | 640 | } | |
| 641 | 641 | ||
0 commit comments