Commit 883840b
deps: patch V8 to run on Xcode 8
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
returning from a function (which is likely a bug on Xcode, considering
this worked on the prior version of Xcode as well as newer versions).
This workaround shouldn't affect the application, since the const
qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
There's also a V8 test passing a const-qualified type to ::Of, but since
we don't test V8 on Xcode 8, it should be fine to leave it as is.
Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
Backport-PR-URL: #33376
PR-URL: #32831
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 3831a54 commit 883840b
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.7', | ||
| 39 | + 'v8_embedder_string': '-node.8', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -129,7 +129,7 @@ void DecodedFunctionNames::AddForTesting(int function_index, | |||
| 129 | 129 | ||
| 130 | 130 | AsmJsOffsetInformation::AsmJsOffsetInformation( | |
| 131 | 131 | Vector<const byte> encoded_offsets) | |
| 132 | - : encoded_offsets_(OwnedVector<const uint8_t>::Of(encoded_offsets)) {} | ||
| 132 | + : encoded_offsets_(OwnedVector<uint8_t>::Of(encoded_offsets)) {} | ||
| 133 | 133 | ||
| 134 | 134 | AsmJsOffsetInformation::~AsmJsOffsetInformation() = default; | |
| 135 | 135 | ||
0 commit comments