Commit 88ab61f
test: accept SIGILL aborts in async-hooks tests
Use common.nodeProcessAborted() for the intentional abort path so
platform-specific abort signals such as SIGILL are accepted.
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
PR-URL: #63687
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failure
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent c63e00e commit 88ab61f
3 files changed
Lines changed: 4 additions & 4 deletions
File tree
- test/async-hooks
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,7 +55,7 @@ if (process.argv[2] === 'child') { | |||
| 55 | 55 | child.on('close', common.mustCall((code, signal) => { | |
| 56 | 56 | if ((common.isAIX || | |
| 57 | 57 | (common.isLinux && process.arch === 'x64')) && | |
| 58 | - signal === 'SIGABRT') { | ||
| 58 | + common.nodeProcessAborted(code, signal)) { | ||
| 59 | 59 | // XXX: The child process could be aborted due to unknown reasons. Work around it. | |
| 60 | 60 | } else { | |
| 61 | 61 | assert.strictEqual(signal, null); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -53,8 +53,8 @@ if (process.argv[2] === 'child') { | |||
| 53 | 53 | ||
| 54 | 54 | child.on('close', common.mustCall((code, signal) => { | |
| 55 | 55 | if ((common.isAIX || | |
| 56 | - (common.isLinux && process.arch === 'x64')) && | ||
| 57 | - signal === 'SIGABRT') { | ||
| 56 | + (common.isLinux && process.arch === 'x64')) && | ||
| 57 | + common.nodeProcessAborted(code, signal)) { | ||
| 58 | 58 | // XXX: The child process could be aborted due to unknown reasons. Work around it. | |
| 59 | 59 | } else { | |
| 60 | 60 | assert.strictEqual(signal, null); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -58,7 +58,7 @@ if (process.argv[2] === 'child') { | |||
| 58 | 58 | child.on('close', common.mustCall((code, signal) => { | |
| 59 | 59 | if ((common.isAIX || | |
| 60 | 60 | (common.isLinux && process.arch === 'x64')) && | |
| 61 | - signal === 'SIGABRT') { | ||
| 61 | + common.nodeProcessAborted(code, signal)) { | ||
| 62 | 62 | // XXX: The child process could be aborted due to unknown reasons. Work around it. | |
| 63 | 63 | } else { | |
| 64 | 64 | assert.strictEqual(signal, null); | |
0 commit comments