Commit 88d760c
benchmark: fix benchmark/run.js handling of --set
run.js does not work with --set as it tries to include it as
options to `fork()` rather than as part of argv for `fork()`. This
doesn't throw an error because of a quirk in `fork()` that silently
accepts arrays for options objects. This will be changing in Node.js
18.x.
PR-URL: #41334
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 1150963 commit 88d760c
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,8 +42,7 @@ if (format === 'csv') { | |||
| 42 | 42 | const filename = benchmarks[i]; | |
| 43 | 43 | const child = fork( | |
| 44 | 44 | path.resolve(__dirname, filename), | |
| 45 | - cli.test ? ['--test'] : [], | ||
| 46 | - cli.optional.set | ||
| 45 | + cli.test ? ['--test'] : cli.optional.set | ||
| 47 | 46 | ); | |
| 48 | 47 | ||
| 49 | 48 | if (format !== 'csv') { | |
0 commit comments