Commit 88ed027
committed
deps: V8: cherry-pick 7ddb8399f9f1
Original commit message:
[msvc] fix ambiguous call to function in assembler test
MSVC is confused by initializer list and default parameter, and reports
an ambiguous call.
test/cctest/test-assembler-arm64.cc(12208): error C2668: 'v8::internal::Clobber': ambiguous call to overloaded function
test-utils-arm64.h(251): note: could be 'void v8::internal::Clobber(v8::internal::MacroAssembler *,v8::internal::CPURegList)'
test-utils-arm64.h(241): note: or 'void v8::internal::Clobber(v8::internal::MacroAssembler *,v8::internal::RegList,const uint64_t)'
Solution is to construct with explicit type.
Bug: v8:13312
Change-Id: I66f5ba48bcdf6eb30035beaf7214a3d26fc9f18b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3913034
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83406}
Refs: v8/v8@7ddb839
PR-URL: #44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 26c651c commit 88ed027
2 files changed
Lines changed: 11 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.9', | ||
| 39 | + 'v8_embedder_string': '-node.10', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12179,35 +12179,35 @@ TEST(peek_poke_unaligned) { | |||
| 12179 | 12179 | // x0-x6 should be unchanged. | |
| 12180 | 12180 | // w10-w12 should contain the lower words of x0-x2. | |
| 12181 | 12181 | __ Poke(x0, 1); | |
| 12182 | - Clobber(&masm, {x0}); | ||
| 12182 | + Clobber(&masm, RegList{x0}); | ||
| 12183 | 12183 | __ Peek(x0, 1); | |
| 12184 | 12184 | __ Poke(x1, 2); | |
| 12185 | - Clobber(&masm, {x1}); | ||
| 12185 | + Clobber(&masm, RegList{x1}); | ||
| 12186 | 12186 | __ Peek(x1, 2); | |
| 12187 | 12187 | __ Poke(x2, 3); | |
| 12188 | - Clobber(&masm, {x2}); | ||
| 12188 | + Clobber(&masm, RegList{x2}); | ||
| 12189 | 12189 | __ Peek(x2, 3); | |
| 12190 | 12190 | __ Poke(x3, 4); | |
| 12191 | - Clobber(&masm, {x3}); | ||
| 12191 | + Clobber(&masm, RegList{x3}); | ||
| 12192 | 12192 | __ Peek(x3, 4); | |
| 12193 | 12193 | __ Poke(x4, 5); | |
| 12194 | - Clobber(&masm, {x4}); | ||
| 12194 | + Clobber(&masm, RegList{x4}); | ||
| 12195 | 12195 | __ Peek(x4, 5); | |
| 12196 | 12196 | __ Poke(x5, 6); | |
| 12197 | - Clobber(&masm, {x5}); | ||
| 12197 | + Clobber(&masm, RegList{x5}); | ||
| 12198 | 12198 | __ Peek(x5, 6); | |
| 12199 | 12199 | __ Poke(x6, 7); | |
| 12200 | - Clobber(&masm, {x6}); | ||
| 12200 | + Clobber(&masm, RegList{x6}); | ||
| 12201 | 12201 | __ Peek(x6, 7); | |
| 12202 | 12202 | ||
| 12203 | 12203 | __ Poke(w0, 1); | |
| 12204 | - Clobber(&masm, {w10}); | ||
| 12204 | + Clobber(&masm, RegList{w10}); | ||
| 12205 | 12205 | __ Peek(w10, 1); | |
| 12206 | 12206 | __ Poke(w1, 2); | |
| 12207 | - Clobber(&masm, {w11}); | ||
| 12207 | + Clobber(&masm, RegList{w11}); | ||
| 12208 | 12208 | __ Peek(w11, 2); | |
| 12209 | 12209 | __ Poke(w2, 3); | |
| 12210 | - Clobber(&masm, {w12}); | ||
| 12210 | + Clobber(&masm, RegList{w12}); | ||
| 12211 | 12211 | __ Peek(w12, 3); | |
| 12212 | 12212 | ||
| 12213 | 12213 | __ Drop(4); | |
0 commit comments