Commit 88f69d3
test: check that this != new.target in addon
Add two checks that are there for expository reasons as much as they are
sanity checks.
PR-URL: #15681
Refs: nodejs/node-addon-api#142
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent db0ba97 commit 88f69d3
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,11 @@ | |||
| 3 | 3 | ||
| 4 | 4 | namespace { | |
| 5 | 5 | ||
| 6 | - inline void NewClass(const v8::FunctionCallbackInfo<v8::Value>&) {} | ||
| 6 | + inline void NewClass(const v8::FunctionCallbackInfo<v8::Value>& args) { | ||
| 7 | + // this != new.target since we are being invoked through super(). | ||
| 8 | + assert(args.IsConstructCall()); | ||
| 9 | + assert(!args.This()->StrictEquals(args.NewTarget())); | ||
| 10 | + } | ||
| 7 | 11 | ||
| 8 | 12 | inline void Initialize(v8::Local<v8::Object> binding) { | |
| 9 | 13 | auto isolate = binding->GetIsolate(); | |
0 commit comments