Commit 89a306b
deps: fix V8 compiler error with clang++-11
Fixes: #33040
error: type 'antlr4::tree::TerminalNode *' cannot be narrowed to
'bool' in initializer list [-Wc++11-narrowing]
ParameterList result{{}, {}, context->VARARGS(), {}};
Occurs twice:
../../deps/v8/src/torque/ast-generator.cc:123:32:
../../deps/v8/src/torque/ast-generator.cc:144:32:
PR-URL: #33094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent 9915774 commit 89a306b
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,7 +33,7 @@ | |||
| 33 | 33 | ||
| 34 | 34 | # Reset this number to 0 on major V8 upgrades. | |
| 35 | 35 | # Increment by one for each non-official patch applied to deps/v8. | |
| 36 | - 'v8_embedder_string': '-node.56', | ||
| 36 | + 'v8_embedder_string': '-node.57', | ||
| 37 | 37 | ||
| 38 | 38 | # Enable disassembler for `--print-code` v8 options | |
| 39 | 39 | 'v8_enable_disassembler': 1, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -120,7 +120,7 @@ Statement* AstGenerator::GetOptionalHelperBody( | |||
| 120 | 120 | ||
| 121 | 121 | antlrcpp::Any AstGenerator::visitParameterList( | |
| 122 | 122 | TorqueParser::ParameterListContext* context) { | |
| 123 | - ParameterList result{{}, {}, context->VARARGS(), {}}; | ||
| 123 | + ParameterList result{{}, {}, context->VARARGS() != nullptr, {}}; | ||
| 124 | 124 | if (context->VARARGS()) { | |
| 125 | 125 | result.arguments_variable = context->IDENTIFIER()->getSymbol()->getText(); | |
| 126 | 126 | } | |
@@ -141,7 +141,7 @@ antlrcpp::Any AstGenerator::visitTypeList( | |||
| 141 | 141 | ||
| 142 | 142 | antlrcpp::Any AstGenerator::visitTypeListMaybeVarArgs( | |
| 143 | 143 | TorqueParser::TypeListMaybeVarArgsContext* context) { | |
| 144 | - ParameterList result{{}, {}, context->VARARGS(), {}}; | ||
| 144 | + ParameterList result{{}, {}, context->VARARGS() != nullptr, {}}; | ||
| 145 | 145 | result.types.reserve(context->type().size()); | |
| 146 | 146 | for (auto* type : context->type()) { | |
| 147 | 147 | result.types.push_back(GetType(type)); | |
0 commit comments