Commit 89fbbc4
http2: simplify timeout tracking
There’s no need to reset the chunk counter for every write.
PR-URL: #19206
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 0602166 commit 89fbbc4
2 files changed
Lines changed: 0 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1630,10 +1630,6 @@ inline Http2Stream* Http2Session::SubmitRequest( | |||
| 1630 | 1630 | return stream; | |
| 1631 | 1631 | } | |
| 1632 | 1632 | ||
| 1633 | - inline void Http2Session::SetChunksSinceLastWrite(size_t n) { | ||
| 1634 | - chunks_sent_since_last_write_ = n; | ||
| 1635 | - } | ||
| 1636 | - | ||
| 1637 | 1633 | // Callback used to receive inbound data from the i/o stream | |
| 1638 | 1634 | void Http2Session::OnStreamRead(ssize_t nread, const uv_buf_t& buf) { | |
| 1639 | 1635 | Http2Scope h2scope(this); | |
@@ -2016,7 +2012,6 @@ inline int Http2Stream::DoWrite(WriteWrap* req_wrap, | |||
| 2016 | 2012 | CHECK(!this->IsDestroyed()); | |
| 2017 | 2013 | CHECK_EQ(send_handle, nullptr); | |
| 2018 | 2014 | Http2Scope h2scope(this); | |
| 2019 | - session_->SetChunksSinceLastWrite(); | ||
| 2020 | 2015 | if (!IsWritable()) { | |
| 2021 | 2016 | req_wrap->Done(UV_EOF); | |
| 2022 | 2017 | return 0; | |
@@ -2519,8 +2514,6 @@ void Http2Stream::RespondFD(const FunctionCallbackInfo<Value>& args) { | |||
| 2519 | 2514 | int64_t length = args[3]->IntegerValue(context).ToChecked(); | |
| 2520 | 2515 | int options = args[4]->IntegerValue(context).ToChecked(); | |
| 2521 | 2516 | ||
| 2522 | - stream->session()->SetChunksSinceLastWrite(); | ||
| 2523 | - | ||
| 2524 | 2517 | Headers list(isolate, context, headers); | |
| 2525 | 2518 | args.GetReturnValue().Set(stream->SubmitFile(fd, *list, list.length(), | |
| 2526 | 2519 | offset, length, options)); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -884,8 +884,6 @@ class Http2Session : public AsyncWrap, public StreamListener { | |||
| 884 | 884 | // Write data to the session | |
| 885 | 885 | inline ssize_t Write(const uv_buf_t* bufs, size_t nbufs); | |
| 886 | 886 | ||
| 887 | - inline void SetChunksSinceLastWrite(size_t n = 0); | ||
| 888 | - | ||
| 889 | 887 | size_t self_size() const override { return sizeof(*this); } | |
| 890 | 888 | ||
| 891 | 889 | inline void GetTrailers(Http2Stream* stream, uint32_t* flags); | |
0 commit comments