Commit 8a7e68f
test: check that 2nd handle.close() call is a nop
Verify that a second call to handle.close() is a no-op.
PR-URL: #6395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent bbf3b3e commit 8a7e68f
2 files changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -20,6 +20,7 @@ if (process.argv[2] === 'child') { | |||
| 20 | 20 | tty.unref(); | |
| 21 | 21 | assert(tty._handle.unrefed(), true); | |
| 22 | 22 | tty._handle.close(common.mustCall(() => assert(tty._handle.unrefed(), true))); | |
| 23 | + tty._handle.close(common.fail); | ||
| 23 | 24 | assert(tty._handle.unrefed(), true); | |
| 24 | 25 | return; | |
| 25 | 26 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,6 +23,7 @@ function makeAssert(message) { | |||
| 23 | 23 | cp.ref(); | |
| 24 | 24 | assert(cp._handle.unrefed(), false); | |
| 25 | 25 | cp._handle.close(common.mustCall(() => assert(cp._handle.unrefed(), true))); | |
| 26 | + cp._handle.close(common.fail); | ||
| 26 | 27 | assert(cp._handle.unrefed(), false); | |
| 27 | 28 | } | |
| 28 | 29 | ||
@@ -41,6 +42,7 @@ function makeAssert(message) { | |||
| 41 | 42 | assert(sock4._handle.unrefed(), false); | |
| 42 | 43 | sock4._handle.close( | |
| 43 | 44 | common.mustCall(() => assert(sock4._handle.unrefed(), true))); | |
| 45 | + sock4._handle.close(common.fail); | ||
| 44 | 46 | assert(sock4._handle.unrefed(), false); | |
| 45 | 47 | ||
| 46 | 48 | const sock6 = dgram.createSocket('udp6'); | |
@@ -52,6 +54,7 @@ function makeAssert(message) { | |||
| 52 | 54 | assert(sock6._handle.unrefed(), false); | |
| 53 | 55 | sock6._handle.close( | |
| 54 | 56 | common.mustCall(() => assert(sock6._handle.unrefed(), true))); | |
| 57 | + sock6._handle.close(common.fail); | ||
| 55 | 58 | assert(sock6._handle.unrefed(), false); | |
| 56 | 59 | } | |
| 57 | 60 | ||
@@ -68,6 +71,7 @@ function makeAssert(message) { | |||
| 68 | 71 | handle.ref(); | |
| 69 | 72 | assert(handle.unrefed(), false); | |
| 70 | 73 | handle.close(common.mustCall(() => assert(handle.unrefed(), true))); | |
| 74 | + handle.close(common.fail); | ||
| 71 | 75 | assert(handle.unrefed(), false); | |
| 72 | 76 | } | |
| 73 | 77 | ||
@@ -88,6 +92,7 @@ function makeAssert(message) { | |||
| 88 | 92 | assert(server._unref, false); | |
| 89 | 93 | server._handle.close( | |
| 90 | 94 | common.mustCall(() => assert(server._handle.unrefed(), true))); | |
| 95 | + server._handle.close(common.fail); | ||
| 91 | 96 | assert(server._handle.unrefed(), false); | |
| 92 | 97 | } | |
| 93 | 98 | ||
@@ -103,5 +108,6 @@ function makeAssert(message) { | |||
| 103 | 108 | assert(timer._handle.unrefed(), false); | |
| 104 | 109 | timer._handle.close( | |
| 105 | 110 | common.mustCall(() => assert(timer._handle.unrefed(), true))); | |
| 111 | + timer._handle.close(common.fail); | ||
| 106 | 112 | assert(timer._handle.unrefed(), false); | |
| 107 | 113 | } | |
0 commit comments