Revert "test: mark test-cluster-bind-privileged-port flaky on arm" · nodejs/node@8a82415 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8a82415

Browse filesBrowse the repository at this point in the historyBrowse files

rvagg

authored and

ruyadorno

committed

Revert "test: mark test-cluster-bind-privileged-port flaky on arm"

This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent f2ac4bb commit 8a82415
Copy full SHA for 8a82415

1 file changed

-3Lines changed: 0 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • parallel.status

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/parallel.status‎

Copy file name to clipboardExpand all lines: test/parallel/parallel.status

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -36,9 +36,6 @@ test-async-hooks-http-parser-destroy: PASS,FLAKY
36	36	# https://github.com/nodejs/node/pull/31178
37	37	test-crypto-dh-stateless: SKIP
38	38	test-crypto-keygen: SKIP
39		- # https://github.com/nodejs/node/issues/36847
40		- test-cluster-bind-privileged-port: PASS,FLAKY
41		- test-cluster-shared-handle-bind-privileged-port: PASS,FLAKY
42	39
43	40	[$system==solaris] # Also applies to SmartOS
44	41

0 commit comments

Comments

0 (0)