net: replace _writableState.finished with writableFinished · nodejs/node@8ad880f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8ad880f

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

net: replace _writableState.finished with writableFinished

Replace usage of quasi-private _writableState.finished with public writableFinished property. PR-URL: #27974 Refs: #445 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent cd78c5e commit 8ad880f
Copy full SHA for 8ad880f

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • net.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/net.js‎

Copy file name to clipboardExpand all lines: lib/net.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -556,7 +556,7 @@ Socket.prototype.destroySoon = function() {
556	556	if (this.writable)
557	557	this.end();
558	558
559		- if (this._writableState.finished)
	559	+ if (this.writableFinished)
560	560	this.destroy();
561	561	else
562	562	this.once('finish', this.destroy);

0 commit comments

Comments

0 (0)