test_runner: do not report an error when tests are passing · nodejs/node@8b02485 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8b02485

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

danielleadams

committed

test_runner: do not report an error when tests are passing

PR-URL: #43919 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 9c699bd commit 8b02485
Copy full SHA for 8b02485

2 files changed

+6-1Lines changed: 6 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/main
  • test_runner.js
• test/parallel
  • test-runner-exit-code.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/main/test_runner.js‎

Copy file name to clipboardExpand all lines: lib/internal/main/test_runner.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -114,7 +114,7 @@ function runTestFile(path) {
114	114	err = error;
115	115	});
116	116
117		- const { 0: { code, signal }, 1: stdout, 2: stderr } = await SafePromiseAll([
	117	+ const { 0: { 0: code, 1: signal }, 1: stdout, 2: stderr } = await SafePromiseAll([
118	118	once(child, 'exit', { signal: t.signal }),
119	119	child.stdout.toArray({ signal: t.signal }),
120	120	child.stderr.toArray({ signal: t.signal }),

Collapse file

‎test/parallel/test-runner-exit-code.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-runner-exit-code.js

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,6 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+ const fixtures = require('../common/fixtures');
3	4	const assert = require('assert');
4	5	const { spawnSync } = require('child_process');
5	6	const { setTimeout } = require('timers/promises');
@@ -28,6 +29,10 @@ if (process.argv[2] === 'child') {
28	29	assert.strictEqual(child.status, 0);
29	30	assert.strictEqual(child.signal, null);
30	31
	32	+ child = spawnSync(process.execPath, ['--test', fixtures.path('test-runner', 'subdir', 'subdir_test.js')]);
	33	+ assert.strictEqual(child.status, 0);
	34	+ assert.strictEqual(child.signal, null);
	35	+
31	36	child = spawnSync(process.execPath, [__filename, 'child', 'fail']);
32	37	assert.strictEqual(child.status, 1);
33	38	assert.strictEqual(child.signal, null);

0 commit comments

Comments

0 (0)