Commit 8b05e32
test: fix flaky test-net-timeout
The check for an 800ms window makesw assumptions about a setTimeout()
not running late etc. Remove it.
Refs: #34289
PR-URL: #38060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent a0492ba commit 8b05e32
1 file changed
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -45,7 +45,6 @@ const echo_server = net.createServer((socket) => { | |||
| 45 | 45 | }); | |
| 46 | 46 | ||
| 47 | 47 | socket.on('data', (d) => { | |
| 48 | - console.log(d); | ||
| 49 | 48 | socket.write(d); | |
| 50 | 49 | }); | |
| 51 | 50 | ||
@@ -105,7 +104,4 @@ process.on('exit', () => { | |||
| 105 | 104 | console.log(`diff = ${diff}`); | |
| 106 | 105 | ||
| 107 | 106 | assert.ok(timeout < diff); | |
| 108 | - | ||
| 109 | - // Allow for 800 milliseconds more | ||
| 110 | - assert.ok(diff < timeout + 800); | ||
| 111 | 107 | }); | |
0 commit comments