build: track PDL files as inputs in inspector GN build · nodejs/node@8b91526 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8b91526

Browse filesBrowse the repository at this point in the historyBrowse files

deepak1556

authored and

aduh95

committed

build: track PDL files as inputs in inspector GN build

The `node_protocol_generated_sources` action was missing `gypi_values.node_pdl_files` from its inputs, causing Ninja to skip regeneration when PDL domain files changed. PR-URL: #62888 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>

1 parent 2af4c89 commit 8b91526
Copy full SHA for 8b91526

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/inspector
  • unofficial.gni

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/inspector/unofficial.gni‎

Copy file name to clipboardExpand all lines: src/inspector/unofficial.gni

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -29,7 +29,7 @@ template("inspector_gn_build") {
29	29	deps = [ ":node_protocol_json" ]
30	30
31	31	outputs = gypi_values.node_inspector_generated_sources
32		- inputs = gypi_values.node_protocol_files + [
	32	+ inputs = gypi_values.node_protocol_files + gypi_values.node_pdl_files + [
33	33	"node_protocol_config.json",
34	34	"$node_gen_dir/src/node_protocol.json",
35	35	]

0 commit comments

Comments

0 (0)