Commit 8b93fdd
src: disable stdio buffering
Disable stdio buffering, it interacts poorly with printf() calls from
elsewhere in the program (e.g., any logging from V8.) Unbreaks among
other things the `--trace_debug_json` switch.
Undoes commit 0966ab9 ("src: force line buffering for stderr"), which
in retrospect is not a proper fix. Turning on line buffering fixed a
flaky test on SmartOS but the test wasn't failing on other platforms,
where stderr wasn't line-buffered either. Mark the test flaky again,
it failed once in a run of 333 tries on the smartos-64 buildbot.
Disabling buffering should be safe even when mixed with non-blocking
stdio I/O because libuv goes to great lengths to reopen the tty file
descriptors and falls back to blocking I/O when that fails.
PR-URL: #7610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 3a43b0d commit 8b93fdd
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,7 +42,10 @@ int wmain(int argc, wchar_t *wargv[]) { | |||
| 42 | 42 | #else | |
| 43 | 43 | // UNIX | |
| 44 | 44 | int main(int argc, char *argv[]) { | |
| 45 | - setvbuf(stderr, NULL, _IOLBF, 1024); | ||
| 45 | + // Disable stdio buffering, it interacts poorly with printf() | ||
| 46 | + // calls elsewhere in the program (e.g., any logging from V8.) | ||
| 47 | + setvbuf(stdout, nullptr, _IONBF, 0); | ||
| 48 | + setvbuf(stderr, nullptr, _IONBF, 0); | ||
| 46 | 49 | return node::Start(argc, argv); | |
| 47 | 50 | } | |
| 48 | 51 | #endif | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -15,6 +15,7 @@ test-tick-processor : PASS,FLAKY | |||
| 15 | 15 | [$system==macos] | |
| 16 | 16 | ||
| 17 | 17 | [$system==solaris] # Also applies to SmartOS | |
| 18 | + test-debug-signal-cluster : PASS,FLAKY | ||
| 18 | 19 | ||
| 19 | 20 | [$system==freebsd] | |
| 20 | 21 | ||
0 commit comments