Commit 8b97e2e
build: add -flax-vector-conversions to V8 build
The flag is on by default in Clang and V8 recently made a change that
makes it necessary with GCC.
Refs: v8/v8@7fbbf93
Refs: https://github.com/llvm/llvm-project/blob/54067c5fbe9fc13ab195cdddb8f17e18d72b5fe4/clang/include/clang/Basic/LangOptions.def#L133-L134
Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html#index-flax-vector-conversions
PR-URL: #51257
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent c7aa397 commit 8b97e2e
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -138,7 +138,11 @@ | |||
| 138 | 138 | 'cflags': [ '-Werror', '-Wno-unknown-pragmas' ], | |
| 139 | 139 | },{ | |
| 140 | 140 | 'cflags!': [ '-Wall', '-Wextra' ], | |
| 141 | - 'cflags': [ '-Wno-return-type' ], | ||
| 141 | + 'cflags': [ | ||
| 142 | + '-Wno-return-type', | ||
| 143 | + # On by default in Clang and V8 requires it at least for arm64. | ||
| 144 | + '-flax-vector-conversions', | ||
| 145 | + ], | ||
| 142 | 146 | }], | |
| 143 | 147 | ['v8_target_arch=="arm"', { | |
| 144 | 148 | 'defines': [ | |
0 commit comments