src: add a condition if the argument of `DomainToUnicode` is empty · nodejs/node@8c33731 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8c33731

Browse filesBrowse the repository at this point in the historyBrowse files

Jungku Lee

authored and

targos

committed

src: add a condition if the argument of DomainToUnicode is empty

PR-URL: #49097 Refs: #46410 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>

1 parent 9e1c531 commit 8c33731
Copy full SHA for 8c33731

1 file changed

+5Lines changed: 5 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_url.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_url.cc‎

Copy file name to clipboardExpand all lines: src/node_url.cc

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -95,6 +95,11 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
95	95	CHECK(args[0]->IsString());
96	96
97	97	std::string input = Utf8Value(env->isolate(), args[0]).ToString();
	98	+ if (input.empty()) {
	99	+ return args.GetReturnValue().Set(
	100	+ String::NewFromUtf8(env->isolate(), "").ToLocalChecked());
	101	+ }
	102	+
98	103	// It is important to have an initial value that contains a special scheme.
99	104	// Since it will change the implementation of `set_hostname` according to URL
100	105	// spec.

0 commit comments

Comments

0 (0)