Commit 8c508b9
deps: V8: revert e3cddbedb205
simdutf's `atomic_binary_to_base64` requires `std::atomic_ref`.
`std::atomic_ref` is only available in LLVM 19, which is only available
in Xcode 16.3, which is only available on macOS 15.
Refs: llvm/llvm-project#76647
Refs: v8/v8@e3cddbe
PR-URL: #58064
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent 88ca828 commit 8c508b9
4 files changed
Lines changed: 6 additions & 73 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.6', | ||
| 41 | + 'v8_embedder_string': '-node.7', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4361,12 +4361,6 @@ cc_library( | |||
| 4361 | 4361 | name = "simdutf", | |
| 4362 | 4362 | srcs = ["third_party/simdutf/simdutf.cpp"], | |
| 4363 | 4363 | hdrs = ["third_party/simdutf/simdutf.h"], | |
| 4364 | - copts = select({ | ||
| 4365 | - "@v8//bazel/config:is_clang": ["-std=c++20"], | ||
| 4366 | - "@v8//bazel/config:is_gcc": ["-std=gnu++2a"], | ||
| 4367 | - "@v8//bazel/config:is_windows": ["/std:c++20"], | ||
| 4368 | - "//conditions:default": [], | ||
| 4369 | - }), | ||
| 4370 | 4364 | ) | |
| 4371 | 4365 | ||
| 4372 | 4366 | v8_library( | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -818,16 +818,11 @@ BUILTIN(Uint8ArrayPrototypeToBase64) { | |||
| 818 | 818 | // is false. | |
| 819 | 819 | // 11. Return CodePointsToString(outAscii). | |
| 820 | 820 | ||
| 821 | - size_t simd_result_size; | ||
| 822 | - if (uint8array->buffer()->is_shared()) { | ||
| 823 | - simd_result_size = simdutf::atomic_binary_to_base64( | ||
| 824 | - std::bit_cast<const char*>(uint8array->GetBuffer()->backing_store()), | ||
| 825 | - length, reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet); | ||
| 826 | - } else { | ||
| 827 | - simd_result_size = simdutf::binary_to_base64( | ||
| 828 | - std::bit_cast<const char*>(uint8array->GetBuffer()->backing_store()), | ||
| 829 | - length, reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet); | ||
| 830 | - } | ||
| 821 | + // TODO(rezvan): Make sure to add a path for SharedArrayBuffers when | ||
| 822 | + // simdutf library got updated. Also, add a test for it. | ||
| 823 | + size_t simd_result_size = simdutf::binary_to_base64( | ||
| 824 | + std::bit_cast<const char*>(uint8array->GetBuffer()->backing_store()), | ||
| 825 | + length, reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet); | ||
| 831 | 826 | DCHECK_EQ(simd_result_size, output_length); | |
| 832 | 827 | USE(simd_result_size); | |
| 833 | 828 | } | |
Lines changed: 0 additions & 56 deletions
This file was deleted.
0 commit comments