events: inline iterationCondition hybrid dispatch closure · nodejs/node@8d48adf · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8d48adf

Browse filesBrowse the repository at this point in the historyBrowse files

slagiewka

authored and

aduh95

committed

events: inline iterationCondition hybrid dispatch closure

While more readable, the removed closure overhead unlocks 10-20% in eventtarget.js benchmark. Signed-off-by: Szymon Łągiewka <slagiewka@users.noreply.github.com> PR-URL: #64473 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

1 parent b827c00 commit 8d48adf
Copy full SHA for 8d48adf

1 file changed

+2-7Lines changed: 2 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • event_target.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/event_target.js‎

Copy file name to clipboardExpand all lines: lib/internal/event_target.js

+2-7Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -806,13 +806,8 @@ class EventTarget {
806	806	let handler = root.next;
807	807	let next;
808	808
809		- const iterationCondition = () => {
810		- if (handler === undefined) {
811		- return false;
812		- }
813		- return root.resistStopPropagation || handler.passive || event?.[kStop] !== true;
814		- };
815		- while (iterationCondition()) {
	809	+ while (handler !== undefined &&
	810	+ (root.resistStopPropagation || handler.passive || event?.[kStop] !== true)) {
816	811	// Cache the next item in case this iteration removes the current one
817	812	next = handler.next;
818	813

0 commit comments

Comments

0 (0)