Commit 8d6b74d
build: enable ASLR (PIE) on OS X
After conducting several benchmarks, I noticed performance losses of
5-10%. As OS X is not a performance critical platform, as already
mentioned by @bnoordhuis, I have removed the -no_pie flag at least for
this platform. I'd love to enable PIE for other platforms if the 5-10%
speed loss is not too high. I would be happy to hear your opinion on
this.
Refs: #33425
PR-URL: #35704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent fff25a0 commit 8d6b74d
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -495,8 +495,7 @@ | |||
| 495 | 495 | ['_type!="static_library"', { | |
| 496 | 496 | 'xcode_settings': { | |
| 497 | 497 | 'OTHER_LDFLAGS': [ | |
| 498 | - '-Wl,-no_pie', | ||
| 499 | - '-Wl,-search_paths_first', | ||
| 498 | + '-Wl,-search_paths_first' | ||
| 500 | 499 | ], | |
| 501 | 500 | }, | |
| 502 | 501 | }], | |
0 commit comments