build: don't pass `--mode` argument to V8 test-runner · nodejs/node@8d84154 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8d84154

Browse filesBrowse the repository at this point in the historyBrowse files

richardlau

authored and

targos

committed

build: don't pass --mode argument to V8 test-runner

V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 1b74d3f commit 8d84154
Copy full SHA for 8d84154

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Makefile

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -665,12 +665,12 @@ test-v8: v8 ## Runs the V8 test suite on deps/v8.
665	665	test-v8-intl: v8
666	666	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
667	667	deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
668		- --mode=$(BUILDTYPE_LOWER) intl \
	668	+ intl \
669	669	$(TAP_V8_INTL)
670	670
671	671	test-v8-benchmarks: v8
672	672	export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
673		- deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
	673	+ deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
674	674	benchmarks \
675	675	$(TAP_V8_BENCHMARKS)
676	676

0 commit comments

Comments

0 (0)