FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix TypeScript support check in jitless mode · nodejs/node@8de391e · GitHub

/ node Public

Commit 8de391e

Browse files
Han5991
authored and
aduh95
committed
lib: fix TypeScript support check in jitless mode
WebAssembly is disabled when Node.js is run with --jitless. The internal TypeScript stripper relies on WebAssembly, and previously failed obscurely with a ReferenceError in this mode. This commit adds an explicit check for WebAssembly support when loading the TypeScript parser. If WebAssembly is unavailable, it now throws a descriptive ERR_WEBASSEMBLY_NOT_SUPPORTED error. Fixes: #61353 PR-URL: #61382 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
1 parent 078cfa2 commit 8de391e

4 files changed

Lines changed: 26 additions & 0 deletions

File tree

‎doc/api/errors.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3346,6 +3346,14 @@ The WASI instance has already started.
33463346

33473347
The WASI instance has not been started.
33483348

3349+
<a id="ERR_WEBASSEMBLY_NOT_SUPPORTED"></a>
3350+
3351+
### `ERR_WEBASSEMBLY_NOT_SUPPORTED`
3352+
3353+
A feature requiring WebAssembly was used, but WebAssembly is not supported or
3354+
has been disabled in the current environment (for example, when running with
3355+
`--jitless`). The error message specifies which feature requires WebAssembly.
3356+
33493357
<a id="ERR_WEBASSEMBLY_RESPONSE"></a>
33503358

33513359
### `ERR_WEBASSEMBLY_RESPONSE`

‎lib/internal/errors.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1892,6 +1892,9 @@ E('ERR_VM_MODULE_NOT_MODULE',
18921892
'Provided module is not an instance of Module', Error);
18931893
E('ERR_VM_MODULE_STATUS', 'Module status %s', Error);
18941894
E('ERR_WASI_ALREADY_STARTED', 'WASI instance has already started', Error);
1895+
E('ERR_WEBASSEMBLY_NOT_SUPPORTED',
1896+
'WebAssembly is not supported in this environment, but is required for %s',
1897+
Error);
18951898
E('ERR_WEBASSEMBLY_RESPONSE', 'WebAssembly response %s', TypeError);
18961899
E('ERR_WORKER_INIT_FAILED', 'Worker initialization failure: %s', Error);
18971900
E('ERR_WORKER_INVALID_EXEC_ARGV', (errors, msg = 'invalid execArgv flags') =>

‎lib/internal/util.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,15 @@ const {
4545
SymbolPrototypeGetDescription,
4646
SymbolReplace,
4747
SymbolSplit,
48+
globalThis,
4849
} = primordials;
4950

5051
const {
5152
codes: {
5253
ERR_NO_CRYPTO,
5354
ERR_NO_TYPESCRIPT,
5455
ERR_UNKNOWN_SIGNAL,
56+
ERR_WEBASSEMBLY_NOT_SUPPORTED,
5557
},
5658
isErrorStackTraceLimitWritable,
5759
overrideStackTrace,
@@ -242,6 +244,8 @@ function assertCrypto() {
242244
function assertTypeScript() {
243245
if (noTypeScript)
244246
throw new ERR_NO_TYPESCRIPT();
247+
if (globalThis.WebAssembly === undefined)
248+
throw new ERR_WEBASSEMBLY_NOT_SUPPORTED('TypeScript');
245249
}
246250

247251
/**

‎test/es-module/test-typescript.mjs‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,3 +342,14 @@ test('check transform types warning', async () => {
342342
assert.match(result.stdout, /Hello, TypeScript!/);
343343
assert.strictEqual(result.code, 0);
344344
});
345+
346+
test('expect error when executing a TypeScript file with --jitless', async () => {
347+
const result = await spawnPromisified(process.execPath, [
348+
'--jitless',
349+
fixtures.path('typescript/ts/test-typescript.ts'),
350+
]);
351+
352+
assert.match(result.stderr, /ERR_WEBASSEMBLY_NOT_SUPPORTED/);
353+
assert.match(result.stderr, /WebAssembly is not supported in this environment, but is required for TypeScript/);
354+
assert.strictEqual(result.code, 1);
355+
});

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL