Commit 8e41dbb
committed
doc: mention cherry-pick edge-case on release
PR-URL: #44408
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 048e440 commit 8e41dbb
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -699,10 +699,16 @@ placeholders (that happens when a change previously landed on another release | |||
| 699 | 699 | branch), keep both version numbers. Convert the YAML field to an array if it is | |
| 700 | 700 | not already one. | |
| 701 | 701 | ||
| 702 | + [It's possible that the `cherry-pick` step will end up adding and/or | ||
| 703 | + changing unwanted lines](https://github.com/nodejs/Release/issues/771), | ||
| 704 | + please validate the changes in `doc/` folder files before confirming/continuing | ||
| 705 | + the cherry-pick step. | ||
| 706 | + | ||
| 702 | 707 | Then finish cherry-picking and push the commit upstream: | |
| 703 | 708 | ||
| 704 | 709 | ```console | |
| 705 | 710 | $ git add src/node_version.h doc | |
| 711 | + $ git diff --staged src doc # read output to validate that changes shows up as expected | ||
| 706 | 712 | $ git cherry-pick --continue | |
| 707 | 713 | $ make lint | |
| 708 | 714 | $ git push upstream main | |
0 commit comments