FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: cleanup unused headers · nodejs/node@8ec0d75 · GitHub

/ node Public

Commit 8ec0d75

Browse files
alferpal
authored and
addaleax
committed
src: cleanup unused headers
Node codebase has evolved a lot in the more than 10 years of its existence. As more features (and code) have been added, changed, removed, it's sometimes hard to keep track of what gets used and what not. This commits attempts to clean some of those potentially left-over headers using suggestions from include-what-you-use Refs: #27531 PR-URL: #30328 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2cf8a7f commit 8ec0d75

22 files changed

Lines changed: 11 additions & 30 deletions

‎src/api/encoding.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#include "node.h"
2-
#include "env-inl.h"
32
#include "string_bytes.h"
43
#include "util-inl.h"
54
#include "v8.h"

‎src/api/utils.cc‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
#include "node.h"
2-
#include "node_internals.h"
3-
#include "util-inl.h"
42

53
#include <csignal>
64

‎src/async_wrap.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include "util-inl.h"
2828

2929
#include "v8.h"
30-
#include "v8-profiler.h"
3130

3231
using v8::Context;
3332
using v8::DontDelete;

‎src/connect_wrap.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
#include "connect_wrap.h"
2-
3-
#include "env-inl.h"
42
#include "req_wrap-inl.h"
5-
#include "util-inl.h"
63

74
namespace node {
85

96
using v8::Local;
107
using v8::Object;
118

9+
class Environment;
1210

1311
ConnectWrap::ConnectWrap(Environment* env,
1412
Local<Object> req_wrap_obj,

‎src/connect_wrap.h‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@
33

44
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
55

6-
#include "env.h"
76
#include "req_wrap-inl.h"
87
#include "async_wrap.h"
9-
#include "v8.h"
108

119
namespace node {
1210

‎src/connection_wrap.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
55

66
#include "stream_wrap.h"
7-
#include "v8.h"
87

98
namespace node {
109

‎src/debug_utils.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#include "debug_utils.h"
22
#include "env-inl.h"
3-
#include "util-inl.h"
43

54
#ifdef __POSIX__
65
#if defined(__linux__)

‎src/env.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include "node_errors.h"
88
#include "node_file.h"
99
#include "node_internals.h"
10-
#include "node_native_module.h"
1110
#include "node_options-inl.h"
1211
#include "node_process.h"
1312
#include "node_v8_platform-inl.h"

‎src/fs_event_wrap.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
#include "async_wrap-inl.h"
2323
#include "env-inl.h"
24-
#include "util-inl.h"
2524
#include "node.h"
2625
#include "handle_wrap.h"
2726
#include "string_bytes.h"

‎src/handle_wrap.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include "async_wrap-inl.h"
2424
#include "env-inl.h"
2525
#include "util-inl.h"
26-
#include "node.h"
2726

2827
namespace node {
2928

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL