test: skip wasm-allocation tests for pointer compression builds · nodejs/node@8f09a1f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 119k

• Code
• Issues 632
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8f09a1f

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

test: skip wasm-allocation tests for pointer compression builds

V8 isolate group initialization forces allocation of the virtual memory cage with pointer compression builds and simply would not work when there is a smaller hard limit on the virtual memory. PR-URL: #58171 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent db7f413 commit 8f09a1f
Copy full SHA for 8f09a1f

2 files changed

+5-1Lines changed: 5 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/wasm-allocation
  • wasm-allocation.status
• tools
  • test.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/wasm-allocation/wasm-allocation.status‎

Copy file name to clipboardExpand all lines: test/wasm-allocation/wasm-allocation.status

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -6,5 +6,5 @@ prefix wasm-allocation
6	6
7	7	[true] # This section applies to all platforms
8	8
9		- [$system!=linux || $asan==on]
	9	+ [$system!=linux || $asan==on || $pointer_compression==on]
10	10	test-wasm-allocation: SKIP

Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1628,6 +1628,9 @@ def get_asan_state(vm, context):
1628	1628	asan = Execute([vm, '-p', 'process.config.variables.asan'], context).stdout.strip()
1629	1629	return "on" if asan == "1" else "off"
1630	1630
	1631	+ def get_pointer_compression_state(vm, context):
	1632	+ pointer_compression = Execute([vm, '-p', 'process.config.variables.v8_enable_pointer_compression'], context).stdout.strip()
	1633	+ return "on" if pointer_compression == "1" else "off"
1631	1634
1632	1635	def Main():
1633	1636	parser = BuildOptions()
@@ -1726,6 +1729,7 @@ def Main():
1726	1729	'arch': vmArch,
1727	1730	'type': get_env_type(vm, options.type, context),
1728	1731	'asan': get_asan_state(vm, context),
	1732	+ 'pointer_compression': get_pointer_compression_state(vm, context),
1729	1733	}
1730	1734	test_list = root.ListTests([], path, context, arch, mode)
1731	1735	unclassified_tests += test_list

0 commit comments

Comments

0 (0)