FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: rename regression tests file names · nodejs/node@8fa5bd3 · GitHub

/ node Public

Commit 8fa5bd3

Browse files
ryzokuken
authored and
BethGriggs
committed
test: rename regression tests file names
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-io-1068 to test-tty-stdin-end - Rename test-regress-GH-io-1811 to test-zlib-kmaxlength-rangeerror - Rename test-regress-GH-node-9326 to test-kill-segfault-freebsd - Rename test-timers-regress-GH-9765 to test-timers-setimmediate-infinite-loop - Rename test-tls-pfx-gh-5100-regr to test-tls-pfx-authorizationerror - Rename test-tls-regr-gh-5108 to test-tls-tlswrap-segfault PR-URL: #19332 Fixes: #19105 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
1 parent f5683a9 commit 8fa5bd3

8 files changed

Lines changed: 64 additions & 40 deletions

test/parallel/test-regress-GH-node-9326.js renamed to test/parallel/test-kill-segfault-freebsd.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
'use strict';
22
require('../common');
3+
4+
// This test ensures Node.js doesn't crash on hitting Ctrl+C in order to
5+
// terminate the currently running process (especially on FreeBSD).
6+
// https://github.com/nodejs/node-v0.x-archive/issues/9326
7+
38
const assert = require('assert');
49
const child_process = require('child_process');
510

‎test/parallel/test-regress-GH-io-1068.js‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/parallel/test-timers-regress-GH-9765.js renamed to test/parallel/test-timers-setimmediate-infinite-loop.js

File renamed without changes.

‎test/parallel/test-tls-pfx-authorizationerror.js‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
'use strict';
2+
const common = require('../common');
3+
if (!common.hasCrypto)
4+
common.skip('node compiled without crypto.');
5+
const fixtures = require('../common/fixtures');
6+
7+
// This test ensures that TLS does not fail to read a self-signed certificate
8+
// and thus throw an `authorizationError`.
9+
// https://github.com/nodejs/node/issues/5100
10+
11+
const assert = require('assert');
12+
const tls = require('tls');
13+
14+
const pfx = fixtures.readKey('agent1-pfx.pem');
15+
16+
const server = tls
17+
.createServer(
18+
{
19+
pfx: pfx,
20+
passphrase: 'sample',
21+
requestCert: true,
22+
rejectUnauthorized: false
23+
},
24+
common.mustCall(function(c) {
25+
assert.strictEqual(c.authorizationError, null);
26+
c.end();
27+
})
28+
)
29+
.listen(0, function() {
30+
const client = tls.connect(
31+
{
32+
port: this.address().port,
33+
pfx: pfx,
34+
passphrase: 'sample',
35+
rejectUnauthorized: false
36+
},
37+
function() {
38+
client.end();
39+
server.close();
40+
}
41+
);
42+
});

‎test/parallel/test-tls-pfx-gh-5100-regr.js‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

test/parallel/test-tls-regr-gh-5108.js renamed to test/parallel/test-tls-tlswrap-segfault.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
11
'use strict';
22
const common = require('../common');
3-
43
if (!common.hasCrypto)
54
common.skip('missing crypto');
5+
const fixtures = require('../common/fixtures');
6+
7+
// This test ensures that Node.js doesn't incur a segfault while accessing
8+
// TLSWrap fields after the parent handle was destroyed.
9+
// https://github.com/nodejs/node/issues/5108
610

711
const assert = require('assert');
812
const tls = require('tls');
9-
const fixtures = require('../common/fixtures');
1013

1114
const options = {
1215
key: fixtures.readKey('agent1-key.pem'),
1316
cert: fixtures.readKey('agent1-cert.pem')
1417
};
1518

16-
1719
const server = tls.createServer(options, function(s) {
1820
s.end('hello');
1921
}).listen(0, function() {
@@ -26,7 +28,6 @@ const server = tls.createServer(options, function(s) {
2628
});
2729
});
2830

29-
3031
function putImmediate(client) {
3132
setImmediate(function() {
3233
if (client.ssl) {

‎test/parallel/test-tty-stdin-end.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
'use strict';
2+
require('../common');
3+
4+
// This test ensures that Node.js doesn't crash on `process.stdin.emit("end")`.
5+
// https://github.com/nodejs/node/issues/1068
6+
7+
process.stdin.emit('end');

test/parallel/test-regress-GH-io-1811.js renamed to test/parallel/test-zlib-kmaxlength-rangeerror.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
'use strict';
2-
32
require('../common');
3+
4+
// This test ensures that zlib throws a RangeError if the final buffer needs to
5+
// be larger than kMaxLength and concatenation fails.
6+
// https://github.com/nodejs/node/pull/1811
7+
48
const assert = require('assert');
59

610
// Change kMaxLength for zlib to trigger the error without having to allocate

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL