src: allow unique_ptrs with custom deleter in memory tracker · nodejs/node@8fa6373 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8fa6373

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

codebytere

committed

src: allow unique_ptrs with custom deleter in memory tracker

Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: #31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 88ccb44 commit 8fa6373
Copy full SHA for 8fa6373

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • memory_tracker-inl.h
  • memory_tracker.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/memory_tracker-inl.h‎

Copy file name to clipboardExpand all lines: src/memory_tracker-inl.h

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -107,9 +107,9 @@ void MemoryTracker::TrackField(const char* edge_name,
107	107	}
108	108	}
109	109
110		- template <typename T>
	110	+ template <typename T, typename D>
111	111	void MemoryTracker::TrackField(const char* edge_name,
112		- const std::unique_ptr<T>& value,
	112	+ const std::unique_ptr<T, D>& value,
113	113	const char* node_name) {
114	114	if (value.get() == nullptr) {
115	115	return;

Collapse file

‎src/memory_tracker.h‎

Copy file name to clipboardExpand all lines: src/memory_tracker.h

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -140,9 +140,9 @@ class MemoryTracker {
140	140	const char* node_name = nullptr);
141	141
142	142	// Shortcut to extract the underlying object out of the smart pointer
143		- template <typename T>
	143	+ template <typename T, typename D>
144	144	inline void TrackField(const char* edge_name,
145		- const std::unique_ptr<T>& value,
	145	+ const std::unique_ptr<T, D>& value,
146	146	const char* node_name = nullptr);
147	147
148	148	template <typename T>

0 commit comments

Comments

0 (0)