perf_hooks: fix checking range of `options.figures` in createHistogram · nodejs/node@8fac4c5 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 8fac4c5

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

juanarbol

committed

perf_hooks: fix checking range of options.figures in createHistogram

For `options.figures`, number between 1 and 5 is allowed. So need to use `validateInteger` to limit max as 5. Refs: https://github.com/nodejs/node/blob/main/doc/api/perf_hooks.md#perf_hookscreatehistogramoptions PR-URL: #45999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 7e1462d commit 8fac4c5
Copy full SHA for 8fac4c5

2 files changed

+8-2Lines changed: 8 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • histogram.js
• test/parallel
  • test-perf-hooks-histogram.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/histogram.js‎

Copy file name to clipboardExpand all lines: lib/internal/histogram.js

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -36,7 +36,6 @@ const {
36	36	validateInteger,
37	37	validateNumber,
38	38	validateObject,
39		- validateUint32,
40	39	} = require('internal/validators');
41	40
42	41	const kDestroy = Symbol('kDestroy');
@@ -368,7 +367,7 @@ function createHistogram(options = kEmptyObject) {
368	367	} else if (highest < 2n * lowest) {
369	368	throw new ERR_INVALID_ARG_VALUE.RangeError('options.highest', highest);
370	369	}
371		- validateUint32(figures, 'options.figures', 1, 5);
	370	+ validateInteger(figures, 'options.figures', 1, 5);
372	371	return internalRecordableHistogram(new _Histogram(lowest, highest, figures));
373	372	}
374	373

Collapse file

‎test/parallel/test-perf-hooks-histogram.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-perf-hooks-histogram.js

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -135,6 +135,13 @@ const { inspect } = require('util');
135	135	});
136	136	});
137	137
	138	+ // Number greater than 5 is not allowed
	139	+ for (const i of [6, 10]) {
	140	+ throws(() => createHistogram({ figures: i }), {
	141	+ code: 'ERR_OUT_OF_RANGE',
	142	+ });
	143	+ }
	144	+
138	145	createHistogram({ lowest: 1, highest: 11, figures: 1 });
139	146	}
140	147

0 commit comments

Comments

0 (0)