Commit 8fe62f8
http2: don't send trailers on a closed connection
There is a race condition between onStreamCloseResponse(), which
removes the wantTrailers listener, and Http2Stream.close(), which
will invalidate the connection. IE, sendTrailers can be called on
a closed connection which would crash with a:
Error [ERR_HTTP2_INVALID_STREAM]: The stream has been destroyed
PR-URL: #23146
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent f98d441 commit 8fe62f8
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -330,7 +330,7 @@ function tryClose(fd) { | |||
| 330 | 330 | function onStreamTrailers() { | |
| 331 | 331 | const stream = this[kOwner]; | |
| 332 | 332 | stream[kState].trailersReady = true; | |
| 333 | - if (stream.destroyed) | ||
| 333 | + if (stream.destroyed || stream.closed) | ||
| 334 | 334 | return; | |
| 335 | 335 | if (!stream.emit('wantTrailers')) { | |
| 336 | 336 | // There are no listeners, send empty trailing HEADERS frame and close. | |
0 commit comments