test: reduce http-server-request-timeouts-mixed flakiness · nodejs/node@900c4c0 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 900c4c0

Browse filesBrowse the repository at this point in the historyBrowse files

nicksia-vgw

authored and

danielleadams

committed

test: reduce http-server-request-timeouts-mixed flakiness

parallel/test-http-server-request-timeouts-mixed.js test was sometimes failing due to insufficient tolerance between the connection timeout checking interval, and the expected timeout specified in the test. This change makes the checking interval more frequent, and decouples the timeout for the check from the checking interval. PR-URL: #44169 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent ceb62e5 commit 900c4c0
Copy full SHA for 900c4c0

1 file changed

+4-3Lines changed: 4 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-server-request-timeouts-mixed.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-server-request-timeouts-mixed.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-server-request-timeouts-mixed.js

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -15,7 +15,7 @@ const responseOk = 'HTTP/1.1 200 OK\r\n';
15	15	const responseTimeout = 'HTTP/1.1 408 Request Timeout\r\n';
16	16
17	17	const headersTimeout = common.platformTimeout(2000);
18		- const connectionsCheckingInterval = headersTimeout / 4;
	18	+ const connectionsCheckingInterval = headersTimeout / 8;
19	19
20	20	const server = createServer({
21	21	headersTimeout,
@@ -76,7 +76,8 @@ server.listen(0, common.mustCall(() => {
76	76
77	77	// Send the second request, stop in the middle of the headers
78	78	request2.client.write(requestBodyPart1);
79		- // Send the second request, stop in the middle of the headers
	79	+
	80	+ // Send the third request and stop in the middle of the headers
80	81	request3.client.write(requestBodyPart1);
81	82	}, headersTimeout * 0.2);
82	83
@@ -111,7 +112,7 @@ server.listen(0, common.mustCall(() => {
111	112
112	113	assert(request1.response.startsWith(responseOk));
113	114	assert(request2.response.startsWith(responseTimeout)); // It is expired due to headersTimeout
114		- }, headersTimeout * 1.2 + connectionsCheckingInterval);
	115	+ }, headersTimeout * 1.4);
115	116
116	117	setTimeout(() => {
117	118	// Complete the body for the fourth request

0 commit comments

Comments

0 (0)