tools: assert that the snapshot can be rehashed in node_mksnapshot · nodejs/node@9085412 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9085412

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

BridgeAR

committed

tools: assert that the snapshot can be rehashed in node_mksnapshot

PR-URL: #28181 Refs: #27365 Refs: #17058 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 833d3d5 commit 9085412
Copy full SHA for 9085412

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tools/snapshot
  • snapshot_builder.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tools/snapshot/snapshot_builder.cc‎

Copy file name to clipboardExpand all lines: tools/snapshot/snapshot_builder.cc

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -96,6 +96,7 @@ std::string SnapshotBuilder::Generate(
96	96	// Must be out of HandleScope
97	97	StartupData blob =
98	98	creator.CreateBlob(SnapshotCreator::FunctionCodeHandling::kClear);
	99	+ CHECK(blob.CanBeRehashed());
99	100	// Must be done while the snapshot creator isolate is entered i.e. the
100	101	// creator is still alive.
101	102	main_instance->Dispose();

0 commit comments

Comments

0 (0)