doc: fix color contrast for anchor marks in dark mode · nodejs/node@9178805 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9178805

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

doc: fix color contrast for anchor marks in dark mode

Currently, in its dark mode, our website background color is #090C15 and our anchor marks are #707070 for a contrast ratio of 3.94 to 1, falling short of the WCAG AA 4.5 to 1. This changes the mark color in dark mode only to #7A7A7A for a color contrast of 4.55 to 1. PR-URL: #39168 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 2cd4141 commit 9178805
Copy full SHA for 9178805

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api_assets
  • style.css

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api_assets/style.css‎

Copy file name to clipboardExpand all lines: doc/api_assets/style.css

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -32,6 +32,7 @@
32	32	--color-fill-app: var(--white);
33	33	--color-fill-side-nav: var(--gray6);
34	34	--color-links: var(--green1);
	35	+ --color-text-mark: var(--gray1);
35	36	--color-text-nav: var(--gray3);
36	37	--color-text-primary: var(--gray6);
37	38	--color-text-secondary: var(--green2);
@@ -42,6 +43,7 @@
42	43	--color-fill-app: var(--black1);
43	44	--color-fill-side-nav: var(--black3);
44	45	--color-links: var(--green5);
	46	+ --color-text-mark: var(--gray5);
45	47	--color-text-primary: var(--white);
46	48	}
47	49
@@ -632,7 +634,7 @@ a code {
632	634
633	635	span > .mark,
634	636	span > .mark:visited {
635		- color: #707070;
	637	+ color: var(--color-text-mark);
636	638	position: absolute;
637	639	top: 0;
638	640	right: 0;

0 commit comments

Comments

0 (0)