Commit 91b2850
test: extend env for test-node-output-errors
Extend, rather than replace, `env` for `test-node-output-errors` so
that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or
`DYLD_LIBRARY_PATH` can run.
PR-URL: #53535
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>1 parent 1de4375 commit 91b2850
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,8 +6,6 @@ import { describe, it } from 'node:test'; | |||
| 6 | 6 | import { pathToFileURL } from 'node:url'; | |
| 7 | 7 | ||
| 8 | 8 | const skipForceColors = | |
| 9 | - process.config.variables.icu_gyp_path !== 'tools/icu/icu-generic.gyp' || | ||
| 10 | - process.config.variables.node_shared_openssl || | ||
| 11 | 9 | (common.isWindows && (Number(os.release().split('.')[0]) !== 10 || Number(os.release().split('.')[2]) < 14393)); // See https://github.com/nodejs/node/pull/33132 | |
| 12 | 10 | ||
| 13 | 11 | ||
@@ -76,7 +74,7 @@ describe('errors output', { concurrency: !process.env.TEST_PARALLEL }, () => { | |||
| 76 | 74 | ]; | |
| 77 | 75 | for (const { name, transform = defaultTransform, env, skip = false } of tests) { | |
| 78 | 76 | it(name, { skip }, async () => { | |
| 79 | - await snapshot.spawnAndAssert(fixtures.path(name), transform, { env }); | ||
| 77 | + await snapshot.spawnAndAssert(fixtures.path(name), transform, { env: { ...env, ...process.env } }); | ||
| 80 | 78 | }); | |
| 81 | 79 | } | |
| 82 | 80 | }); | |
0 commit comments