Commit 9226322
stream: avoid function call where possible
Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.
Refs: #41488 (review)
PR-URL: #41534
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>1 parent 878b2e7 commit 9226322
1 file changed
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -118,17 +118,19 @@ function isReadableFinished(stream, strict) { | |||
| 118 | 118 | ||
| 119 | 119 | function isReadable(stream) { | |
| 120 | 120 | if (stream && stream[kIsReadable] != null) return stream[kIsReadable]; | |
| 121 | - const r = isReadableNodeStream(stream); | ||
| 122 | 121 | if (typeof stream?.readable !== 'boolean') return null; | |
| 123 | 122 | if (isDestroyed(stream)) return false; | |
| 124 | - return r && stream.readable && !isReadableFinished(stream); | ||
| 123 | + return isReadableNodeStream(stream) && | ||
| 124 | + stream.readable && | ||
| 125 | + !isReadableFinished(stream); | ||
| 125 | 126 | } | |
| 126 | 127 | ||
| 127 | 128 | function isWritable(stream) { | |
| 128 | - const r = isWritableNodeStream(stream); | ||
| 129 | 129 | if (typeof stream?.writable !== 'boolean') return null; | |
| 130 | 130 | if (isDestroyed(stream)) return false; | |
| 131 | - return r && stream.writable && !isWritableEnded(stream); | ||
| 131 | + return isWritableNodeStream(stream) && | ||
| 132 | + stream.writable && | ||
| 133 | + !isWritableEnded(stream); | ||
| 132 | 134 | } | |
| 133 | 135 | ||
| 134 | 136 | function isFinished(stream, opts) { | |
0 commit comments