Commit 93416e9
build: fix newlines in addon build output
Interpretation of escape sequences with echo is not as consistent
across platforms as printf, so use the latter instead.
PR-URL: #11466
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 7f273c6 commit 93416e9
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -169,7 +169,7 @@ test/addons/.buildstamp: config.gypi \ | |||
| 169 | 169 | # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | |
| 170 | 170 | # embedded addons have been generated from the documentation. | |
| 171 | 171 | @for dirname in test/addons/*/; do \ | |
| 172 | - echo "\nBuilding addon $$PWD/$$dirname" ; \ | ||
| 172 | + printf "\nBuilding addon $$PWD/$$dirname\n" ; \ | ||
| 173 | 173 | env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \ | |
| 174 | 174 | --loglevel=$(LOGLEVEL) rebuild \ | |
| 175 | 175 | --python="$(PYTHON)" \ | |
0 commit comments