crypto: always return certificate serial numbers as uppercase · nodejs/node@938841e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 938841e

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

aduh95

committed

crypto: always return certificate serial numbers as uppercase

This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values. Refs: #61459 (comment) PR-URL: #61752 Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 9db82ba commit 938841e
Copy full SHA for 938841e

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/crypto
  • crypto_x509.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/crypto/crypto_x509.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_x509.cc

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -253,8 +253,8 @@ MaybeLocal<Value> GetSignatureAlgorithmOID(Environment* env,
253	253
254	254	MaybeLocal<Value> GetSerialNumber(Environment* env, const X509View& view) {
255	255	if (auto serial = view.getSerialNumber()) {
256		- return OneByteString(env->isolate(),
257		- static_cast<unsigned char*>(serial.get()));
	256	+ return ToV8Value(
	257	+ env, ToUpper(std::string_view(static_cast<char*>(serial.get()))));
258	258	}
259	259	return Undefined(env->isolate());
260	260	}

0 commit comments

Comments

0 (0)