Commit 939f8e8
fs: throw rm() validation errors
This commit updates validateRmOptions() to throw on input
validation failures. This is consistent with how Node handles
validation in most places across the codebase.
PR-URL: #35602
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent cd0b136 commit 939f8e8
1 file changed
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -673,12 +673,8 @@ const defaultRmdirOptions = { | |||
| 673 | 673 | }; | |
| 674 | 674 | ||
| 675 | 675 | const validateRmOptions = hideStackFrames((path, options, callback) => { | |
| 676 | - try { | ||
| 677 | - options = validateRmdirOptions(options, defaultRmOptions); | ||
| 678 | - validateBoolean(options.force, 'options.force'); | ||
| 679 | - } catch (err) { | ||
| 680 | - return callback(err); | ||
| 681 | - } | ||
| 676 | + options = validateRmdirOptions(options, defaultRmOptions); | ||
| 677 | + validateBoolean(options.force, 'options.force'); | ||
| 682 | 678 | ||
| 683 | 679 | lazyLoadFs().stat(path, (err, stats) => { | |
| 684 | 680 | if (err) { | |
0 commit comments