Commit 93bacfd
test: remove unneeded bind() and related comments
As mentioned in the comment of the changed file, "a libuv limitation
makes it necessary to bind()". But, that is not the case in this test.
The subsequent call to send() results in an implicit bind().
PR-URL: #5023
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>1 parent 98b721e commit 93bacfd
1 file changed
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -132,10 +132,6 @@ if (process.argv[2] !== 'child') { | |||
| 132 | 132 | } | |
| 133 | 133 | ||
| 134 | 134 | var sendSocket = dgram.createSocket('udp4'); | |
| 135 | - // FIXME: a libuv limitation makes it necessary to bind() | ||
| 136 | - // before calling any of the set*() functions. The bind() | ||
| 137 | - // call is what creates the actual socket. | ||
| 138 | - sendSocket.bind(); | ||
| 139 | 135 | ||
| 140 | 136 | // The socket is actually created async now. | |
| 141 | 137 | sendSocket.on('listening', function() { | |
0 commit comments