src: use BaseObjectPtr for keeping channel alive in dns bindings · nodejs/node@940a297 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 940a297

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

MylesBorins

committed

src: use BaseObjectPtr for keeping channel alive in dns bindings

PR-URL: #30374 Refs: nodejs/quic#141 Refs: nodejs/quic#149 Refs: nodejs/quic#141 Refs: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

1 parent 6665881 commit 940a297
Copy full SHA for 940a297

1 file changed

+1-5Lines changed: 1 addition & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • cares_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/cares_wrap.cc‎

Copy file name to clipboardExpand all lines: src/cares_wrap.cc

+1-5Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -575,10 +575,6 @@ class QueryWrap : public AsyncWrap {
575	575	: AsyncWrap(channel->env(), req_wrap_obj, AsyncWrap::PROVIDER_QUERYWRAP),
576	576	channel_(channel),
577	577	trace_name_(name) {
578		- // Make sure the channel object stays alive during the query lifetime.
579		- req_wrap_obj->Set(env()->context(),
580		- env()->channel_string(),
581		- channel->object()).Check();
582	578	}
583	579
584	580	~QueryWrap() override {
@@ -735,7 +731,7 @@ class QueryWrap : public AsyncWrap {
735	731	UNREACHABLE();
736	732	}
737	733
738		- ChannelWrap* channel_;
	734	+ BaseObjectPtr<ChannelWrap> channel_;
739	735
740	736	private:
741	737	std::unique_ptr<ResponseData> response_data_;

0 commit comments

Comments

0 (0)