lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array · nodejs/node@9438c83 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9438c83

Browse filesBrowse the repository at this point in the historyBrowse files

Jah-yee

authored and

aduh95

committed

lib: narrow ReadableStreamBYOBRequest.view return type to Uint8Array

Follow WHATWG streams spec update: whatwg/streams#1367 ReadableStreamBYOBRequest.view is always constructed as a Uint8Array. This changes the documented return type from ArrayBufferView to Uint8Array per the updated spec. Fixes: #62952 Signed-off-by: Jah-yee <166608075+Jah-yee@users.noreply.github.com> PR-URL: #63017 Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com>

1 parent 9091398 commit 9438c83
Copy full SHA for 9438c83

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/webstreams
  • readablestream.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/webstreams/readablestream.js‎

Copy file name to clipboardExpand all lines: lib/internal/webstreams/readablestream.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -665,7 +665,7 @@ class ReadableStreamBYOBRequest {
665	665
666	666	/**
667	667	* @readonly
668		- * @type {ArrayBufferView}
	668	+ * @type {Uint8Array}
669	669	*/
670	670	get view() {
671	671	if (!isReadableStreamBYOBRequest(this))

0 commit comments

Comments

0 (0)