Commit 94a486a
build: add v8 requirement to test-v8* in Makefile
The test targets expect that V8 is built in deps/v8/out
Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e562727 commit 94a486a
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -246,22 +246,22 @@ test-timers-clean: | |||
| 246 | 246 | ||
| 247 | 247 | ||
| 248 | 248 | ifneq ("","$(wildcard deps/v8/tools/run-tests.py)") | |
| 249 | - test-v8: | ||
| 249 | + test-v8: v8 | ||
| 250 | 250 | # note: performs full test unless QUICKCHECK is specified | |
| 251 | 251 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 252 | 252 | --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \ | |
| 253 | 253 | --no-presubmit \ | |
| 254 | 254 | --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ | |
| 255 | 255 | $(TAP_V8) | |
| 256 | 256 | ||
| 257 | - test-v8-intl: | ||
| 257 | + test-v8-intl: v8 | ||
| 258 | 258 | # note: performs full test unless QUICKCHECK is specified | |
| 259 | 259 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 260 | 260 | --mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \ | |
| 261 | 261 | --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \ | |
| 262 | 262 | $(TAP_V8_INTL) | |
| 263 | 263 | ||
| 264 | - test-v8-benchmarks: | ||
| 264 | + test-v8-benchmarks: v8 | ||
| 265 | 265 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \ | |
| 266 | 266 | --download-data $(QUICKCHECK_ARG) --no-presubmit \ | |
| 267 | 267 | --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \ | |
0 commit comments