Commit 94e980c
committed
src: use non-deprecated overload of V8::SetFlagsFromString
PR-URL: #28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>1 parent 1dd31fe commit 94e980c
2 files changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -945,7 +945,8 @@ void Init(int* argc, | |||
| 945 | 945 | } | |
| 946 | 946 | ||
| 947 | 947 | if (per_process::cli_options->print_v8_help) { | |
| 948 | - V8::SetFlagsFromString("--help", 6); // Doesn't return. | ||
| 948 | + // Doesn't return. | ||
| 949 | + V8::SetFlagsFromString("--help", static_cast<size_t>(6)); | ||
| 949 | 950 | UNREACHABLE(); | |
| 950 | 951 | } | |
| 951 | 952 | ||
@@ -1002,7 +1003,8 @@ InitializationResult InitializeOncePerProcess(int argc, char** argv) { | |||
| 1002 | 1003 | } | |
| 1003 | 1004 | ||
| 1004 | 1005 | if (per_process::cli_options->print_v8_help) { | |
| 1005 | - V8::SetFlagsFromString("--help", 6); // Doesn't return. | ||
| 1006 | + // Doesn't return. | ||
| 1007 | + V8::SetFlagsFromString("--help", static_cast<size_t>(6)); | ||
| 1006 | 1008 | UNREACHABLE(); | |
| 1007 | 1009 | } | |
| 1008 | 1010 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -139,7 +139,7 @@ void UpdateHeapCodeStatisticsArrayBuffer( | |||
| 139 | 139 | void SetFlagsFromString(const FunctionCallbackInfo<Value>& args) { | |
| 140 | 140 | CHECK(args[0]->IsString()); | |
| 141 | 141 | String::Utf8Value flags(args.GetIsolate(), args[0]); | |
| 142 | - V8::SetFlagsFromString(*flags, flags.length()); | ||
| 142 | + V8::SetFlagsFromString(*flags, static_cast<size_t>(flags.length())); | ||
| 143 | 143 | } | |
| 144 | 144 | ||
| 145 | 145 | ||
0 commit comments