Commit 95f2213
deps: always define V8_NODISCARD as no-op
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.
PR-URL: #54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 09d997f commit 95f2213
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.5', | ||
| 39 | + 'v8_embedder_string': '-node.6', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -677,7 +677,7 @@ path. Add it with -I<path> to the command line | |||
| 677 | 677 | // V8_NODISCARD Foo() { ... }; | |
| 678 | 678 | // [[nodiscard]] comes in C++17 but supported in clang with -std >= c++11. | |
| 679 | 679 | #if V8_HAS_CPP_ATTRIBUTE_NODISCARD | |
| 680 | - #define V8_NODISCARD [[nodiscard]] | ||
| 680 | + #define V8_NODISCARD | ||
| 681 | 681 | #else | |
| 682 | 682 | #define V8_NODISCARD /* NOT SUPPORTED */ | |
| 683 | 683 | #endif | |
0 commit comments