events: add stop propagation flag to `Event.stopImmediatePropagation` · nodejs/node@96566fc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 96566fc

Browse filesBrowse the repository at this point in the historyBrowse files

mikemadest

authored and

targos

committed

events: add stop propagation flag to Event.stopImmediatePropagation

Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: #39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent afe39ed commit 96566fc
Copy full SHA for 96566fc

2 files changed

+6Lines changed: 6 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • event_target.js
• test/parallel
  • test-eventtarget.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/event_target.js‎

Copy file name to clipboardExpand all lines: lib/internal/event_target.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -168,6 +168,10 @@ class Event {
168	168	stopImmediatePropagation() {
169	169	if (!isEvent(this))
170	170	throw new ERR_INVALID_THIS('Event');
	171	+ // Spec mention "stopImmediatePropagation should set both "stop propagation"
	172	+ // and "stop immediate propagation" flags"
	173	+ // cf: from https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation
	174	+ this.stopPropagation();
171	175	this[kStop] = true;
172	176	}
173	177

Collapse file

‎test/parallel/test-eventtarget.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-eventtarget.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -345,7 +345,9 @@ let asyncTest = Promise.resolve();
345	345	{
346	346	const target = new EventTarget();
347	347	const event = new Event('foo');
	348	+ strictEqual(event.cancelBubble, false);
348	349	event.stopImmediatePropagation();
	350	+ strictEqual(event.cancelBubble, true);
349	351	target.addEventListener('foo', common.mustNotCall());
350	352	target.dispatchEvent(event);
351	353	}

0 commit comments

Comments

0 (0)