src: add file name to 'Module did not self-register' error · nodejs/node@966404f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 966404f

Browse filesBrowse the repository at this point in the historyBrowse files

nornagon

authored and

MylesBorins

committed

src: add file name to 'Module did not self-register' error

PR-URL: #30125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent b775753 commit 966404f
Copy full SHA for 966404f

4 files changed

+10-4Lines changed: 10 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_binding.cc
• test/addons
  • dlopen-ping-pong
    • test-worker.js
    • test.js
  • not-a-binding
    • test.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_binding.cc‎

Copy file name to clipboardExpand all lines: src/node_binding.cc

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -484,7 +484,12 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
484	484	mp = dlib->GetSavedModuleFromGlobalHandleMap();
485	485	if (mp == nullptr || mp->nm_context_register_func == nullptr) {
486	486	dlib->Close();
487		- env->ThrowError("Module did not self-register.");
	487	+ char errmsg[1024];
	488	+ snprintf(errmsg,
	489	+ sizeof(errmsg),
	490	+ "Module did not self-register: '%s'.",
	491	+ *filename);
	492	+ env->ThrowError(errmsg);
488	493	return false;
489	494	}
490	495	}

Collapse file

‎test/addons/dlopen-ping-pong/test-worker.js‎

Copy file name to clipboardExpand all lines: test/addons/dlopen-ping-pong/test-worker.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -16,5 +16,6 @@ require(bindingPath);
16	16	new Worker(`require(${JSON.stringify(bindingPath)})`, { eval: true })
17	17	.on('error', common.mustCall((err) => {
18	18	assert.strictEqual(err.constructor, Error);
19		- assert.strictEqual(err.message, 'Module did not self-register.');
	19	+ assert.strictEqual(err.message,
	20	+ `Module did not self-register: '${bindingPath}'.`);
20	21	}));

Collapse file

‎test/addons/dlopen-ping-pong/test.js‎

Copy file name to clipboardExpand all lines: test/addons/dlopen-ping-pong/test.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -19,5 +19,5 @@ assert.strictEqual(module.exports.ping(), 'pong');
19	19	// Check that after the addon is loaded with
20	20	// process.dlopen() a require() call fails.
21	21	console.log('require:', `./build/${common.buildType}/binding`);
22		- const re = /^Error: Module did not self-register\.$/;
	22	+ const re = /^Error: Module did not self-register: '.*[\\/]binding\.node'\.$/;
23	23	assert.throws(() => require(`./build/${common.buildType}/binding`), re);

Collapse file

‎test/addons/not-a-binding/test.js‎

Copy file name to clipboardExpand all lines: test/addons/not-a-binding/test.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -2,5 +2,5 @@
2	2	const common = require('../../common');
3	3	const assert = require('assert');
4	4
5		- const re = /^Error: Module did not self-register\.$/;
	5	+ const re = /^Error: Module did not self-register: '.*[\\/]binding\.node'\.$/;
6	6	assert.throws(() => require(`./build/${common.buildType}/binding`), re);

0 commit comments

Comments

0 (0)